moda20 / facebook-scraper

Scrape Facebook public pages without an API key
MIT License
88 stars 28 forks source link

Fix "LoginRequired" detection on MBASIC #36

Closed volodkindv closed 9 months ago

volodkindv commented 9 months ago

Fix: "LoginRequired" does not raised on mbasic.facebook.com

image

volodkindv commented 9 months ago

@moda20 check please

moda20 commented 9 months ago

@volodkindv that's a great catch, but before we merge the PR, your second red box highlights the existence of a secondversion of the login requirement ape title, is this for mbasic ? do you mean we need to add this as potential test title?

volodkindv commented 9 months ago

do you mean we need to add this as potential test title?

No, I think it's better to compare URL than title. It's just for understanding, because I lost some time trying to figure out the reason.

moda20 commented 9 months ago

@volodkindv I see, we can keep them both, i'll merge this PR