build docker image - Githubissues

modal-inria / MixtComp

Model-based clustering package for mixed data

Other

13 stars 4 forks source link

build docker image #32

Closed MostafaAbdelrashied closed 1 year ago

MostafaAbdelrashied commented 1 year ago

This PR is created to solve #31 and #30

Creating a Makefile to build and run docker images locally
Enforce minimum python version on users to avoid malfunction on certain platforms
Enforce specific versions of python packages to be future proof

MostafaAbdelrashied commented 1 year ago

I wanted to locate the docker file in pyMixtCompt as it is only relevant for this component. However, we will need to still copy/use the MixtComp folder for building, and docker doesn't allow relative imports.

From the documentation: The path must be inside the context of the build; you cannot COPY ../something/something, because the first step of a docker build is to send the context directory (and subdirectories) to the docker daemon.

MostafaAbdelrashied commented 1 year ago

I agree with you that adding only python-related Dockerfile/Makefile to the root is not optimal, but it was the only way to do it. At my work, it has eased a lot of the installation process across different platforms. Thus, I thought it might be useful for others.

Anyway, I will close the PR for now