search

modal-inria / MixtComp

Model-based clustering package for mixed data
Other
12 stars 4 forks source link

Use c++17 as default instead of c++ #35

Closed Quentin62 closed 1 year ago

Quentin62 commented 1 year ago

From Brian

random_shuffle was replaced by shuffle in C++11

Full message

That is

BET RMixtCompIO chngpt cit diversityForest fbati fdaPDE genepop geojsonsf ggraph jsonify keyATM lmSubsets mapdeck mapscanner matchingMarkets plfm prioritizr quanteda.textmodels ranger ruimtehol sctransform sgd sirus spatialwidget stream

You will notice that R CMD check is now reporting

  • checking C++ specification ... NOTE Specified C++11: please update to current default of C++17

and we investigated for those packages if a non-default C++ standard was actually needed. For all but 26 out of 1205 it was not. Common issues

random_shuffle was replaced by shuffle in C++11: BET RMixtCompIO cit ggraph matchingMarkets sctransform sgd stream

bind1st was deprecated in C++11 and removed in C++17: chngpt

diversityForest ranger sirus: define own make_unique (a C++14 addition) in a namespace but do not qualify the usages.

fbati genepop quanteda.textmodels : 'data' clashes with C++17 headers which have std::data.

CRAN submissions will now auto-reject packages with this NOTE, so do update before your next submission.