Reusing a single client session in blob utils - Githubissues

modal-labs / modal-client

Python client library for Modal

https://modal.com/docs

Apache License 2.0

271 stars 35 forks source link

Reusing a single client session in blob utils #1958

Closed TheQuantumFractal closed 3 months ago

TheQuantumFractal commented 3 months ago

Describe your changes

Addresses MOD-2004. This change sets up a registry that creates a ClientSession on the first request and destroys the ClientSession on shutdown.

Check these boxes or delete any item (or this section) if not relevant for this PR.

[x] Client+Server: this change is compatible with old servers
[x] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to multiple entities (client, server, worker, database). See points above.

Changelog

Persisting ClientSession to make upload / download of blobs faster