Skip logging heartbeat exceptions locally when losing connection in detached mode

modal-labs / modal-client

Python client library for Modal

https://modal.com/docs

Apache License 2.0

271 stars 35 forks source link

Skip logging heartbeat exceptions locally when losing connection in detached mode #1967

Closed kramstrom closed 2 months ago

kramstrom commented 3 months ago

Addresses MOD-3007

Adds flag to infine_loop whether to log exceptions or not. When running the heartbeat loop in detached mode this flag is set to false as the client can lose the connection with the app still running fine and the exceptions are confusing, suggesting something broke. Instead it will just print that it couldn't fetch the logs as normal