modcluster / mod_proxy_cluster

mod_cluster is an intelligent native Apache httpd-based and pure-Java Undertow-based load-balancer
https://www.modcluster.io
Apache License 2.0
7 stars 15 forks source link

Add RELEASING.md with necessary instructions #246

Closed jajik closed 2 months ago

jajik commented 4 months ago

close #244

jajik commented 4 months ago

@rhusar Looking at expected checks, we need to change the settings after #248

rhusar commented 4 months ago

Thats funny, doesn't seem to be very well thought out. The only option is to remove all required checks which in turn disables other functionality..

jajik commented 4 months ago

What? :D

edit: Oh no https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

jajik commented 4 months ago

So it seems the workaround is this

https://github.com/laurencee/GithubActionTesting/commit/876ef30bc6aff6f981ff829dbee72f3ef2e2714c

Seriously :smiley:

rhusar commented 3 months ago

Thats funny, doesn't seem to be very well thought out. The only option is to remove all required checks which in turn disables other functionality..

Just for record, it disables this one:

Require branches to be up to date before merging
This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled (see below).
jajik commented 3 months ago

Just for record, it disables this one:

Require branches to be up to date before merging
This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled (see below).

So you cannot enforce linear history without that?

rhusar commented 3 months ago

Just for record, it disables this one:

Require branches to be up to date before merging
This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled (see below).

So you cannot enforce linear history without that?

I think you mean by 'linear history' changes being tested linearly / on top of each other and IIRC yes, this would remove the notification about branches not being up 2 date, which given we don't have a large turnover in this repo we want to keep.

I am thinking now let's go with your workaround.

rhusar commented 3 months ago

Just for record, it disables this one:

Require branches to be up to date before merging
This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled (see below).

So you cannot enforce linear history without that?

I think you mean by 'linear history' changes being tested linearly / on top of each other and IIRC yes, this would remove the notification about branches not being up 2 date, which given we don't have a large turnover in this repo we want to keep.

I am thinking now let's go with your workaround.

OK merged - please rebase and see if this works.

rhusar commented 3 months ago

Just for record, it disables this one:

Require branches to be up to date before merging
This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled (see below).

So you cannot enforce linear history without that?

I think you mean by 'linear history' changes being tested linearly / on top of each other and IIRC yes, this would remove the notification about branches not being up 2 date, which given we don't have a large turnover in this repo we want to keep. I am thinking now let's go with your workaround.

OK merged - please rebase and see if this works.

OK thanks, the workaround looks good - and it's clear that the checks were indeed skipped.