search

modcluster / mod_proxy_cluster

mod_cluster is an intelligent native Apache httpd-based and pure-Java Undertow-based load-balancer
https://www.modcluster.io
Apache License 2.0
7 stars 15 forks source link

Improve handling of received parameters in mod_manager.c #285

Closed jajik closed 1 month ago

jajik commented 1 month ago

There are commands whose parameters may change settings of the proxy but their processing repeats code and checks only non-default options. E.g.

if (strcasecmp(key, "Reversed") == 0) {
    if (strcasecmp(val, "yes") == 0) {
        nodeinfo->mess.reversed = 1;
    }
}

We should update this approach with some appropriate abstraction covering all options.

jajik commented 1 month ago

To be clear, for example requests with following options Reversed=yes&Reversed=no are not handled properly.