modded-factorio / SeaBlock

Factorio mod pack Sea Block
https://mods.factorio.com/mod/SeaBlock
MIT License
22 stars 18 forks source link

Added Landblock setting, No Ores Setting, and No Trees/Rock Setting #297

Open zerostarm opened 1 year ago

zerostarm commented 1 year ago

Added three settings named Landblock mode, no minerals mode, and no trees setting. The Landblock setting (default off) sets the map generation to normal for tiles and spawners, but does not affect resources, or trees/rocks. The no minerals mode (default on) makes it so that ores don't generate, this is added for mod compatibility (looking at you Modmash Underground). The no trees setting (default on) makes it so that both normal trees and rocks don't spawn. I put this in to complete the set/aesthetic reasons.

All three are startup settings, and have been localized for English.

Also for the Landblock mode to recover normal biter activity the Angel-biter-slider setting has to bet set to 600%. This is not the default behavior and I don't know how to change it.

zerostarm commented 1 year ago

Covers of #32. And some of #12.

KiwiHawk commented 1 year ago

Sounds good, thanks! I've been meaning to add a Land Block setting. I'm a bit busy IRL but will get this reviewed before the next release 🙂

KiwiHawk commented 1 year ago

Can you please add more explanation as to why the No Minerals setting is required? As far as I'm concerned, this is Sea Block. Ores should never spawn!

KiwiHawk commented 1 year ago

Also not sure that we should ever be allowing Cargo Ship's deep Sea oil to spawn. It's against the ethos of Sea Block. Everything is made from water!

KiwiHawk commented 1 year ago

Rather than having a Landblock as a setting, I would much prefer to have it a map type. Selectable from the map gen screen. Maybe also override the vanilla "Island" map type.

zerostarm commented 1 year ago

Can you please add more explanation as to why the No Minerals setting is required? As far as I'm concerned, this is Sea Block. Ores should never spawn!

Mod compatibility, some mods break if there are no ores at all/placeable.

Also just an option in-case some people want to experience the mod without quite as high of a barrier to entry

zerostarm commented 1 year ago

Also not sure that we should ever be allowing Cargo Ship's deep Sea oil to spawn. It's against the ethos of Sea Block. Everything is made from water!

Also just an option in-case some people want to experience the mod without quite as high of a barrier to entry. I find the oil stuff with blue algae a pain and thought this was a pretty close way of getting around it without mucking too much up and staying as close as possible to the theme of Seablock. Since you still have to explore the ocean and setup infrastructure to obtain the oil and still do refining, I thought it was a close to reasonable trade-off. It also makes some more interaction with the sea part of Seablock if people want that.

zerostarm commented 1 year ago

Also all of these settings I've made default to traditional Seablock settings so if someone downloads the mod and starts up a world with the meta pack it should have no ores, no minerals, and no Cargo ships oil.

zerostarm commented 1 year ago

Rather than having a Landblock as a setting, I would much prefer to have it a map type. Selectable from the map gen screen. Maybe also override the vanilla "Island" map type.

As the code is written right now, that might be hard. The base Seablock code literally deletes all of the ores multiple times and all I did was write exceptions for the cases above. Mainly just to get them working, even if in the most inefficient way.

I'll try it sometime though, I also am busy with stuff IRL.

KiwiHawk commented 1 year ago

Mod compatibility, some mods break if there are no ores at all/placeable.

Also just an option in-case some people want to experience the mod without quite as high of a barrier to entry

I've not had any reports of this kind of issue in the time I've been maintaining Sea Block. If there are issues with particular mods, we can look at them on a case by case basis.

KiwiHawk commented 1 year ago

I find the oil stuff with blue algae a pain

Once you get mid way through blue science, you can move entirely away from Blue Algae.

zerostarm commented 1 year ago

I find the oil stuff with blue algae a pain

Once you get mid way through blue science, you can move entirely away from Blue Algae.

Huh, I did not notice that.