modded-factorio / bobsmods

Factorio mods by Bobingabout
https://mods.factorio.com/user/Bobingabout
Other
65 stars 31 forks source link

Mining drill color masks #188

Open Qatavin opened 4 months ago

Qatavin commented 4 months ago

new miner test new miner test 2

I decided to make color masks for the mining drills because of a separate request someone made for the B+SE mod, but they seem like a good fit for baseline Bob's too, if this meets with approval. Colors are still up for revision, but I personally think they look better being not quite as bright and saturated as assembly machines etc. are.

The total size of all 18 required graphics files is only 63.4 KB.

I'd like to do new icons for them as well, but haven't finished them yet.

In the runup to 2.0, perhaps we should consider color masks for a few other things too, like oil refineries, and maybe even nuclear reactors. although in the latter case, their different heat pipes and working glow colors are probably good enough.

KiwiHawk commented 4 months ago

@Qatavin Graphics look good!

In the interest of avoiding rework: Have you seen Artisanl Reskins: Bob's Mods ? Kira has done a lot of work on reskinning already. I can't remember which entities he still hasn't touched yet.

Qatavin commented 4 months ago

I have checked it out, and it adds color to the drill unit on top of the miners, but not to the cladding in the front. There's no conflicts between the two additions, so I'd say we're good to go with this.

On the topic of Artisanal Reskins in general, while I do greatly enjoy vibrantly colorful things, and there are certain graphics that I'm wondering if we could ask to port over (artifacts, glass, small fluid tanks, bullet components, and plenty of others), I find that a lot of the revised entity graphics are a little too colorful, to the point that they start to look... un-industrial, or toy-like, is how I suppose I would put it. Large fluid tanks, steam engines, and nuclear reactors would be examples of that, where I would favor a more subtle style to make the coloration an accent, and not so in-your-face.

So, as far as looking to Artisanal Reskins for this sort of thing, I would say sometimes yes and sometimes maybe not.

KiwiHawk commented 4 months ago

Yeah, definitely agree about the over colourful thing! @kirazy How do you feel about porting some of the graphics into Bob's directly?

kirazy commented 4 months ago

I'm not necessarily opposed.

Some reasons I chose not to do the miner masks the way they are done in this suggestion:

It may be simpler to augment AR with additional options/color masks to provide the desired coloration. That maintains the cross-mod compatibility with supporting mods and e.g. Angel's.

I had been idly-dreaming of breaking out the masks into a resource-pack-type thing consumed like a library by other mods, with methods that can be called to skin various entities however a mod desires. AR would then become a consumer mod that uses the assets indirectly, rather than host the assets. That may be a preferred approach. Then bobs can use all the masks in AR without the AR logic.

Qatavin commented 4 months ago

Fortunately, it's not like everything has to be colored in the same way. In the case of storage tanks, recoloring them to resemble the pipes made from the same materials seems like a perfectly workable solution.

As for the large area mining drills, there is certainly more than can be done to differentiate them, and I do plan to keep working on that.

What I'm really hoping for is for us to be able to replace a lot of the old, outdated sprites with the excellent, snazzy AR ones. In particular, the sprites for...

Qatavin commented 4 months ago

new miner test 3

Did another version of the large area mining drills. These will be easier to tell apart with their two-color cladding. The regular drills remain unchanged from the above images. If these are approved, I'll go ahead and make the pull request to implement them.

KiwiHawk commented 4 months ago

Looks good to me!

Qatavin commented 4 months ago

new storage tank test

Threw this together fairly quick. I'm not totally happy with the colors, but I think the masks are pretty good. Chem plants included for comparison.