mode / alamode

A community-maintained library of visualizations for Mode reports
MIT License
70 stars 67 forks source link

Encoding of '&' character #31

Open biabbiassago opened 6 years ago

biabbiassago commented 6 years ago

Hello,

I have come across the following issue using the 'alamode' template. I am using the addLinksToTables function as described here https://community.modeanalytics.com/gallery/table-links/.

However, one of the entries in my column includes an ampersand '&' sign (say, like 'arts & crafts', which does not get encoded so it breaks the link. The problem is that the url does get encoded by the function, but the actual column name does not (so the following does not cover case with ampersand):

line 124 if alamode.js: cells.eq(columnToShow).html("" + cellContent + "")

If I encodeURIComponents before passing it to the addLinksToTables function, the table does not recognize the format properly. I could have not found a proper work around this.

Any chance the function could be modified to account for this specific case?

Thank you!!