search

mode / alamode

A community-maintained library of visualizations for Mode reports
MIT License
70 stars 67 forks source link

Adds support to specify a gradient_by cohort or pivot columns #44

Closed MiguelMadero closed 4 years ago

MiguelMadero commented 4 years ago

When defining the gradient based on the pivot_column we can more easily compare how well each cohort performed at any given point in time. cc: @leqilong

leqilong commented 4 years ago

Hi @MiguelMadero , thank you for the PR. The code looks good and seems to be non-breaking from what I've seen. Just one small thing, you would also want to update the minified version of alamode.js in this PR. We have an instruction here on how to minify it. Once you update the minified file, I'll go ahead and approve. Thanks!

MiguelMadero commented 4 years ago

@leqilong thanks! and sorry for the delay, I just saw this. I rebased from master and updated the minified file.

Please let me know if there is anything else missing. I'll keep a closer eye on this repo.

leqilong commented 4 years ago

Thanks @MiguelMadero ! I've deployed your changes!