search

mode / alamode

A community-maintained library of visualizations for Mode reports
MIT License
70 stars 67 forks source link

Fix gradientValue undefined error #49

Closed cedomir closed 4 years ago

cedomir commented 4 years ago

When using retentionHeatmap, if a dataValue is not present for a specific pivotValue, an error is currently thrown because gradientValue is not defined.

SaraaraS commented 4 years ago

Hey @cedomir thanks for the fix, looks like gradientValue and entryValue are both throwing as globals right now because they aren't ever defined, what do you think about putting var gradientValue = ''; var entryValue = ''; at the top of the foreach loop so they are scoped to this function and the error is fixed?

SaraaraS commented 4 years ago

@cedomir I'm gonna go ahead an close this pr because it was addressed here - https://github.com/mode/alamode/pull/51

Thanks so much!