search

modeco80 / mdrpc

Discord Rich Presence for MPV - as a native plugin
MIT License
2 stars 0 forks source link

mdrpc doesn't work with certain streams that only have an icy-title and nothing else. #3

Closed re9177 closed 1 year ago

re9177 commented 2 years ago

OS: debian bookworm/sid x86_64 mpv version: 0.34.1

it does hook onto my discord client and displays my username, but afterwards constantly outputs this error message until i quit mpv.

radio used (that has only icy-title): http://radio.modules.pl:8500/

screenshot of what happens: image

re9177 commented 2 years ago

can't reproduce issue with another stream that also has only an icy-title http://scenestream.net:8000/nectarine, however title itself doesn't display only the stream name does.

image

modeco80 commented 2 years ago

hm. I honestly probably need to completely rewrite this thing for a multitude of reasons (several of them being my poor wrapping of mpv apis, although no one's really made an alternative API wrapper for C++ so :woman_shrugging:)

I'd also like to maybe be able to use upstream rpc/GameSDK, or better yet, completely remove the need for vendoring by writing my own async client library (as I really do NOT like the forced inclusion of rapidjson), as that seems more stable then pinning to a version of the rpc SDK which I've hacked to use std::function<R(Args...)> instead of bare function pointers.