search

model-bakers / model_bakery

Object factory for Django
https://model-bakery.readthedocs.io/en/latest/
Other
846 stars 85 forks source link

Replace tox with GitHub Actions matrix #437

Closed amureki closed 1 year ago

aqeelat commented 1 year ago

@amureki I think this PR should be reverted. Tox allows us to run the tests locally. You can still use both but I think tox has a great value. For example, before upgrading to django 4.2, I had to locally clone all of the packages we use that did not officially declare support for django 4.2 and run their tests against django 4.2 and python 3.11. Tox was a godsend.

amureki commented 1 year ago

@amureki I think this PR should be reverted. Tox allows us to run the tests locally. You can still use both but I think tox has a great value. For example, before upgrading to django 4.2, I had to locally clone all of the packages we use that did not officially declare support for django 4.2 and run their tests against django 4.2 and python 3.11. Tox was a godsend.

Excellent point! I had simplicity in mind while working on this change, however did not consider such use-cases like yours. 🫣 I'll bring tox back soon.

amureki commented 1 year ago

@aqeelat hey there! I brought back tox, together with Python 3.12 prerelease support.

Thanks again for the report.

Best, Rust