search

model-checking / cbmc-viewer

CBMC Viewer scans the output of CBMC and produces a browsable summary of its findings, making it easy to root cause the issues it finds.
https://model-checking.github.io/cbmc-viewer/
Apache License 2.0
32 stars 11 forks source link

Run differential tests from Python 3.6 until 3.10 #113

Closed angelonakos closed 2 years ago

angelonakos commented 2 years ago

Issue #, if available:

Description of changes:

Update GitHub Actions workflow.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

markrtuttle commented 2 years ago

I think it is unlikely this regression test is going to work because the run script in the http repository depends on features not in 3.6.

angelonakos commented 2 years ago

I think it is unlikely this regression test is going to work because the run script in the http repository depends on features not in 3.6.

If we ignore the failed, cancelled checks and merge this PR, then the differential tests in #116 should run with Python versions 3.6 though 3.10, right?

Actually, on second thought, the workflow itself must be updated in order to run on ubuntu-18.04 aside for ubuntu-latest

markrtuttle commented 2 years ago

I don't understand what this pull request is trying to accomplish. We know it will fail with 3.6, maybe even 3.7. Why merge something that we know is hopeless?

angelonakos commented 2 years ago

I don't understand what this pull request is trying to accomplish. We know it will fail with 3.6, maybe even 3.7. Why merge something that we know is hopeless?

I closed the PR. It can be re-opened again once we expect the differential tests to succeed with both 3.6 and 3.7

In addition, as can be seen in the checks in this page, the jobs that attempted to run in Ubuntu 18.04 failed due to the universal-ctags package not being found.