search

modelfoxdotdev / modelfox

ModelFox makes it easy to train, deploy, and monitor machine learning models.
Other
1.46k stars 63 forks source link

correct overall row count computation and fix ui to reflect splits #79

Closed isabella closed 2 years ago

isabella commented 2 years ago
image
isabella commented 2 years ago

This PR updates the row counts to add the comparison rows to the overall row count. For models trained before this change, the total_row_count was computed by adding the train_row_count and the test_row_count. It omitted the comparison_row_count so the total_row_count was undercounting the total number of rows in the csv. This change does not add a comparison_row_count to the model file, rather it computes the comparison_row_count by subtracting the train_row_count and test_row_count from the total_row_count. For models trained after this change, everything should appear correct in the UI. However, this results in a comparison_row_count of 0 for models trained before this change. A complete solution that does not result in the UI reporting a comparison row count of 0 would be to add a comparison_row_count to the model file and for models that do not have this field, compute what the comparison_row_count would have been. @nitsky