Interpret 'null' as missing in production statistics

modelfoxdotdev / modelfox

ModelFox makes it easy to train, deploy, and monitor machine learning models.

Other

1.46k stars 63 forks source link

Interpret 'null' as missing in production statistics #92

Closed wgoodall01 closed 2 years ago

wgoodall01 commented 2 years ago

Previously, null was considered an invalid value when calculating statistics. This led to a bug where two similar JSON values, {} and {"a": null}, were interpreted differently: the empty object incremented absent_count, while the null-valued object incremented invalid_count.

This PR changes this behavior so that null is always interpreted as absent for the purposes of statistics.

Closes #85

wgoodall01 commented 2 years ago

@nitsky Just made those two changes we talked about (rewording values -> variants, stat -> stats)