modelica-3rdparty / ElectricalEnergyStorage

Free library that contains models with different complexity for simulating of electric energy storages like batteries (single cells as well as stacks) interacting with loads, battery management systems, loads and charging devices.
46 stars 19 forks source link

Missing default values in records #10

Open casella opened 4 years ago

casella commented 4 years ago

Please check the OpenModelica coverage report of your library. All models fail to compile because records are instantiated without giving values to some elements, that have no default value.

I guess other Modelica tools may use the start attribute as default, but I'm not sure if this is legal Modelica when you have record constructors. In any case, indicating the default explicitly in the record definition would be much clearer.