search

modelica-3rdparty / ElectricalEnergyStorage

Free library that contains models with different complexity for simulating of electric energy storages like batteries (single cells as well as stacks) interacting with loads, battery management systems, loads and charging devices.
46 stars 19 forks source link

EnergyStorages is lacking test models and complete documentation #3

Open modelica-trac-importer opened 7 years ago

modelica-trac-importer commented 7 years ago

Reported by dietmarw on 10 Oct 2012 09:51 UTC The for milestone:MSL3.2.1 newly introduced sublibrary Electrical.EnergyStorages is lacking quite a bit of documentation. Now in the past we made it quite clear to improve that aspect of the MSL. So introducing a new sub-library which lacks documentation is not helping.

Therefore either the new sub-library is drastically improved in a way that all components are documented or the inclusion should be simply postponed and the library put on the web as Modelica_EnergyStorages instead for now.

Another aspect is that EnergyStorages does not provide any kind of test models so far. This in itself should be a 100% blocker for new models.

Now we've learned what this means to include a new sub-library too early from the pre-mature inclusion of Spice3 (which resulted in a enormous amount of extra work and a series of obsoleted models already now). We really don't want to go down that road once again. Now personally I think that the EnergyStorages library is very useful and I'm happy to use it but then I can also debug it if need occurs. This is something that we should not expect of the normal MSL user.

Migrated-From: https://trac.modelica.org/Modelica/ticket/868

modelica-trac-importer commented 7 years ago

Comment by dietmarw on 3 Dec 2012 23:26 UTC As of r5692 EnergyStorages is not part of the MSL anymore and was moved back to https://svn.modelica.org/projects/Modelica_ElectricalSystems/Modelica_EnergyStorages in ea8cbdaf1f95bd2508a2e3e944dd7d88dd06748b.

This library needs to be improved in order to be added to the MSL. To make versioning simpler I simply set this version to 3.2 to mark that it is compatible with MSL 3.2 and follow the same track as for example ModelicaServices.

In order to include this library into the MSL we should follow a proper process which is:

  1. Add the library under the name Modelica_EnergyStorages on ​https://modelica/libraries
  2. If the library contains enough test coverage and documentation the MA can vote again on its inclusion to the MSL

A possible candidate of inclusion of that library could be MSL 3.3 given tests and documentation is provided.

modelica-trac-importer commented 7 years ago

Modified by dietmarw on 4 Dec 2012 16:32 UTC

modelica-trac-importer commented 7 years ago

Modified by beutlich on 18 Jun 2014 09:34 UTC