search

modelica-3rdparty / ExternalMedia

The ExternalMedia library provides a framework for interfacing external codes computing fluid properties to Modelica.Media-compatible component models.
53 stars 36 forks source link

Use typeless void* for structs in exported interface functions, see #73 #74

Closed rfranke closed 1 year ago

rfranke commented 1 year ago

Modelica does not treat struct types in external function calls. Typeless void* prevent compiler warnings in C and errors in C++ due to incompatible pointer types.

fedetftpolimi commented 1 year ago

Patch looks good, waiting for @casella to approve it.

rfranke commented 1 year ago

It works nicely with the Modelica code of the released 3.3.1 version. The current master branch introduces *_wrap functions that exhibit the same problem.

fedetftpolimi commented 1 year ago

I talked to @casella , I'll merge the patch myself. I'm testing it right now.

fedetftpolimi commented 1 year ago

Patches were merged from command line, thanks! For some reason this pr is still listed as open on the web interface, so I'm closing this.