search

modelica-3rdparty / Modelica_DeviceDrivers

Free library for interfacing hardware drivers to Modelica models. There is support for joysticks, keyboards, UDP, TCP/IP, LCM, MQTT, shared memory, AD/DA converters, serial port and other devices.
BSD 3-Clause "New" or "Revised" License
77 stars 31 forks source link

Compile libMDDSpaceMouse.a with -fPIC #388

Closed bernhard-thiele closed 3 months ago

bernhard-thiele commented 3 months ago

Problem: Linking Resources/Library/linux64/libMDDSpaceMouse.a/libMDDSpaceMouse.a fails when trying to make a shared object.

Solution: Push a binary which was compiled with the -fPIC option.

tbeu commented 3 months ago

OT: Prefered workflow on GitHub (instead of creating an self-assigned issue and closing via magic keyword in commit message during direct push to master) could be to create a PR, enable auto-merge with squash and let the CI checks succeed. What do you think? The benefit I see is the green CI.

bernhard-thiele commented 3 months ago

You are right. I bypassed that in a hurry, but the workflow with CI is much better.