Add Windows platform support for string streams

modelica-3rdparty / msgpack-modelica

A MessagePack implementation as a Modelica package

BSD 2-Clause "Simplified" License

6 stars 4 forks source link

Add Windows platform support for string streams #14

Closed tbeu closed 9 years ago

tbeu commented 9 years ago

See #7

tbeu commented 9 years ago

Are you interested in this PR?

[ ] Sure, wait.
[ ] Sorry, don't bother me with that Win stuff.

sjoelund commented 9 years ago

I think if this is added, msgpack-c should also be part of the repository (Ubuntu still does not ship 1.0)

tbeu commented 9 years ago

Yeah, simply add it. It is only a small number of C files and headers.

sjoelund commented 9 years ago

@dietmarw @mtiller how does impact handle git submodule? I assume you use github-generated zip-files, which do not contain these files?

tbeu commented 9 years ago

Use KISS: Just copy the files.

sjoelund commented 9 years ago

No, that is just stupid when I want to update things :) git subtree is a possibility if submodule is not supported.

tbeu commented 9 years ago

Yes, stupid but simple.

sjoelund commented 9 years ago

It is sadly not that simple, because the includes in the msgpack-c repository do not work if you do #include "msgpack-c/include/msgpack.h". The reason is that msgpack internally uses: #include <msgpack/predef.h> - this only works if a -I directive points to the directory containing msgpack...

tbeu commented 9 years ago

Why does it not work like this https://github.com/tbeu/msgpack-modelica/tree/issue-12-binaries/MessagePack/Resources/Include for you?

sjoelund commented 9 years ago

https://github.com/msgpack/msgpack-c/issues/367 ... might be possible with some weird IncludeDirectory...