modelica-3rdparty / netCDF-DataReader

Modelica library for interfacing netCDF files using different interpolation and extrapolation methods
http://www.j-raedler.de/projects/ncdatareader2
GNU Lesser General Public License v2.1
8 stars 6 forks source link

Annotation with relative Include/Library directories #3

Closed PMehrfeld closed 7 years ago

PMehrfeld commented 7 years ago

We are aiming to use the NcDataReader2 library in the AixLib (https://github.com/RWTH-EBC/AixLib/issues/313). Since we found some improvement regarding the annotation to include external files, it is not necessary anylonger to copy the files into the working directory. The annotation is like: Include = "#include <ncDataReaderEA.h>", IncludeDirectory = "modelica://NcDataReader2/Resources/Include", Especially the ...Directory commands are not implemented in the current master. Similar, but with focus on 32 bit, is done in BuildingSystems: https://github.com/UdK-VPT/BuildingSystems/blob/master/BuildingSystems/Utilities/NcDataReader2/ncEasyGet1D.mo

Additionally, due to the 32/64 bit folder structure, the correct files will be chosen. This was tested with Dymola 2017.

We could also create our own solution like in BuildingSystems. But in my opinion it is better to keep the dependency to this repo in order to stay up to date.

Is it okay, if we fork a branch and make a PR afterwards?

tbeu commented 7 years ago

Is it okay, if we fork a branch and make a PR afterwards?

Sure, that's the way OSS contribution works and is stated in the readme file. Thanks!

PMehrfeld commented 7 years ago

Thanks for merging. I close this issue due to #4

thorade commented 7 years ago

Minor comment @PMehrfeld : All the links in your text are broken, you can just paste any URL as text and it will be converted: https://github.com/RWTH-EBC/AixLib/issues/313 https://github.com/UdK-VPT/BuildingSystems/blob/master/BuildingSystems/Utilities/NcDataReader2/ncEasyGet1D.mo This will also create the backlinks in the other issues.

tbeu commented 7 years ago

@thorade Links are fixed now.