modelica-3rdparty / netCDF-DataReader

Modelica library for interfacing netCDF files using different interpolation and extrapolation methods
http://www.j-raedler.de/projects/ncdatareader2
GNU Lesser General Public License v2.1
8 stars 6 forks source link

Add dll files and annotation enhancement to include directories #4

Closed PMehrfeld closed 7 years ago

PMehrfeld commented 7 years ago

as discussed in #2 and #3

tbeu commented 7 years ago

About 871d6fccb4b038b69f8b06d011364264809aa5f3: I'd like to stick with netcdf 4.3.3.1 pre-built binaries for the following reasons

Two options (for me) here:

So if it is OK for you, I'd simply would add the binaries from the netcdf 4.3.3.1 binary distribution.

tbeu commented 7 years ago

About f39385a668d2df9ef1bc042cc5fe8be9014cc7c1: According to the MLS 3.3 rev1, section 12.9.4 the IncludeDirectory and LibraryDirectory you added are the default ones and need not be specified. Do you really require these annotations for your Modelica tool? Additionally, __iti_dllDirectory is not defined by SimulationX.

PMehrfeld commented 7 years ago

I have replaced dll files with the ones from netCDF 4.3.3.1. Still works. But we need these files, otherwise compilation aborts. You are absolutely right. The suffix ...Directory is not needed in the annotation. I reverted this.

tbeu commented 7 years ago

Thanks, merged manually.