modelica-tools / atom-language-modelica

Modelica language support for the atom editor
https://atom.io/packages/language-modelica
Other
8 stars 4 forks source link

Adapt coding style to modelica.cson #24

Closed lochel closed 9 years ago

lochel commented 9 years ago

I think we should use the same coding style for modelica.cson and modelicascript.cson.

thorade commented 9 years ago

This is doing two things:

No changes to the content / no functional changes, correct? Then you can just merge it.

thorade commented 9 years ago

One more comment: If you change a lot of whitespace, then it is good practice to put all the whitespace changes in one commit and everything else in another (or mutliple other) commits. Then it becomes a bit easier to see what happened. Related: Ignore Whitepsace in the diff by appending ?w=1 to the commit URL: https://github.com/lochel/atom-language-modelica/commit/a154876f14914335d476fa5368c26c31bcb9312c?w=1

https://github.com/blog/967-github-secrets

lochel commented 9 years ago

@thorade good hint, thanks.

bilderbuchi commented 9 years ago

btw this works on many github pages, e.g. this PRs diff view