modelica-tools / atom-language-modelica

Modelica language support for the atom editor
https://atom.io/packages/language-modelica
Other
8 stars 4 forks source link

Fix syntax highlighting #35

Closed lochel closed 7 years ago

lochel commented 7 years ago

Adapt syntax highlighting according to SimplyDanny/modelica-language-vscode#3. I haven’t tested this with atom yet.

bilderbuchi commented 7 years ago

Do you have a test string/model that can be used with lighthouse to check the bug you found & fixed?

lochel commented 7 years ago

Sure, sorry for the lazy description. It is about the following kind of patterns: Foo.Bar(foo2.bar2("foo bar"));

Now, I have also tested it with atom and it looks good.

lochel commented 7 years ago

This is the bug: link And this is how it should look like: link

bilderbuchi commented 7 years ago

Thank you!

thorade commented 7 years ago

Looks good to me. Should I merge it and publish a patch release?

lochel commented 7 years ago

Yes, I think this can be merged.