search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
479 stars 169 forks source link

Partial interfaces in particular package in Modelica.Thermal.FluidHeatFlow.Interfaces #2479

Closed tobolar closed 5 years ago

tobolar commented 6 years ago

There are collected partial interface classes in a particular subpackage Modelica.Thermal.FluidHeatFlow.Interfaces.Partials. This is not common in the MSL and the classes should be moved one level higher, i.e. into Modelica.Thermal.FluidHeatFlow.Interfaces.

christiankral commented 6 years ago

We also use sub packages in Modelica.Electrical.Machines.Interfaces to structure the partial models. I think it would even make sense to structure Modelica.Electrical.Machines.Interfaces by the data types boolean, integer and real.

tobolar commented 6 years ago

In Modelica.Electrical.Machines.Interfaces, the situation may be different to FluidHeatFlow.Interfaces. I would rather compare to

The interfaces defined in those packages reveal a similar idea, but the Partials subpackage is used only in FluidHeatFlow.

christiankral commented 5 years ago

I agree, we shall move the partials one level up and keep the names as they are. I will prepare a PR.