modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
476 stars 169 forks source link

Questionable initialScale in some Blocks #2512

Open tobolar opened 6 years ago

tobolar commented 6 years ago

In the following blocks, there is used initialScale=0.06 without obvious benefit.

If there is a benefit, the same scaling should be used consequently within other (partial) classes such as Modelica.Blocks.Interfaces.SISO.

In contrast, in Modelica.Blocks.Interfaces.PartialBooleanSISO_small, the name at least indicates the scaling. Though it may not be obvious to the user what feature is reflected by "small". See also #2419.

MartinOtter commented 6 years ago

Please look at the blocks where these interfaces are used (like MultiSum). The purpose was to have "smaller" blocks for "trivial" operations like "*" or "+". Just try it out by dragging the corresponding blocks.

tobolar commented 6 years ago

I understand that it is reasonable to have smaller blocks in some cases. But my impression is that this decission is fully arbitrary.

Regarding only MISO partial blocks, there is set initialScale=0.06 in

but no such definition in (complementary?)

The situation is even worse for SISO. initialScale=0.06 is set only in

but no such definition e. g. in

And there are far more partial blocks MIMO, SIMO.

But maybe better to consider the issue from another perspective. We can compare the blocks package-wise, e.g. from Logical and MathBoolean since the blocks in those packages often look very similar. Then:

So my question is actually how is the decission procedure whether (and how) the blocks are scaled per default or not. Once such the procedure is clear, it should be documented in Modelica.UsersGuide.Conventions.Icons.

tobolar commented 3 years ago

Resolve #2164 first.