search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
472 stars 168 forks source link

Redesign FreeMotionScalarInit to not influence dynamic simulation when no states are selected #2556

Open tobolar opened 6 years ago

tobolar commented 6 years ago

In #1810, @HansOlsson discuss the problematic design of Modelica.Mechanics.MultiBody.Joints.FreeMotionScalarInit concerning its influence on dynamic simulation. A solution should be found and implemented on calculation of angles, angular velocity and acceleration when no states are selected. The suggested solution is

replacing its internal InitAngle (and its derivative) by the corresponding sensor components

See also PR #2529.

beutlich commented 5 years ago

@tobolar This is labeled "high" and originated from https://github.com/modelica/ModelicaStandardLibrary/pull/2529#issuecomment-392700692. Do you think you can provide a fix for MSL v4.0.0?

tobolar commented 4 years ago

I will look at it again.

beutlich commented 4 years ago

Thanks. Just want to make sure that "high" issues are not forgotten.

tobolar commented 4 years ago

A possible solution is prepared in https://github.com/tobolar/ModelicaStandardLibrary/tree/issue2556_FreeMotionScalarInit. Will wait with a PR for merging of #3396.

beutlich commented 4 years ago

Will wait with a PR for merging of #3396.

Done.