modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
466 stars 166 forks source link

Units.LogarithmicDecrement has units of Ohms (1/S). #3853

Open JoeRiel opened 3 years ago

JoeRiel commented 3 years ago

Possibly the intention was 1/s, but even that doesn't make sense. It should be dimensionless.

HansOlsson commented 2 years ago

Assuming it is the same as https://en.wikipedia.org/wiki/Logarithmic_decrement I agree that it should be dimensionless. As far I can see it is not documented and not used in MSL so I cannot be certain that I interpret it correctly.

christiankral commented 1 year ago

I agree with @JoeRiel: Units.LogarithmicDecrement shall be dimensionless.