search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
470 stars 168 forks source link

Duplicate non-identical component in Modelica.Electrical.QuasiStatic.Polyphase.Sources.FrequencySweepVoltageSource #4021

Closed filip-stenstrom closed 2 years ago

filip-stenstrom commented 2 years ago

The component m is declared multiple times in Modelica.Electrical.QuasiStatic.Polyphase.Sources.FrequencySweepVoltageSource, but they are not identical.

Locally:

parameter Integer m=3 "Number of phases" annotation(Evaluate=true);

Inherited from Modelica.Electrical.QuasiStatic.Polyphase.Interfaces.TwoPlug which inherits it from Modelica.Electrical.QuasiStatic.Polyphase.Interfaces.TwoPlugElementary:

parameter Integer m(min=1) = 3 "Number of phases" annotation(Evaluate=true);

The specification requires that duplicate components are identical (MLS 3.4,, 5.6.1.4).

AHaumer commented 2 years ago

Thanks @filip-stenstrom for ponting this out. The same issue can be found in Modelica.Electrical.QuasiStatic.Polyphase.Sources.FrequencySweepCurrentSource. Both fixed with PR #4022