Open tobolar opened 10 months ago
It seems MapleSim's moparser can yet not deal with the "selective model extension". ;-) https://github.com/modelica/ModelicaStandardLibrary/actions/runs/6848246047/job/18618044784
The new version of MapleSim's moparser allows it. But I do not know how to upload it. The github page for it was archived. I sent an email to @dietmarw.
The new version of MapleSim's moparser allows it. But I do not know how to upload it. The github page for it was archived. I sent an email to @dietmarw.
PRs are now accepted again. Thanks! It is appreciated.
Syntax checks still fail with MapleSim Stand-Alone Modelica Parser 3.6 (after branch rebase).
@beutlich what version of moparser is used for the checks? It works for me. To double check, I downloaded the latest version from the github page and the files from this PR. Tested on Linux64 and Windows 64. Both returned no errors. Note that 32 bit platforms are no longer built, so the files were not updated (only 3.4 grammar) and just moved to the Obsolete folder.
what version of moparser is used for the checks
MapleSim Stand-Alone Modelica Parser 3.6, see https://github.com/modelica/ModelicaStandardLibrary/actions/runs/6912730662/job/18808801660?pr=4231
If you click on the triangle next to "Run echo "::add-matcher::./.github/moparser.json"" in that link, it looks like the version for moparser
is explicitly set the version to 3.4:
ModelicaSyntaxChecker/Linux64/moparser -v 3.4 -r Complex.mo Modelica ModelicaReference ModelicaServices ModelicaTest ModelicaTestConversion4.mo
The workflow would need to be updated to call -v 3.6
or completely remove -v
option, to rely on the default version.
If you click on the triangle next to "Run echo "::add-matcher::./.github/moparser.json"" in that link,
The confusing is, MapleSim reports in right that link that it is 3.6:
MapleSim Stand-Alone Modelica Parser 3.6 Copyright (c) 2023 by Maplesoft. May be freely used for library ...
If you click on the triangle next to "Run echo "::add-matcher::./.github/moparser.json"" in that link, it looks like the version for
moparser
is explicitly set the version to 3.4:ModelicaSyntaxChecker/Linux64/moparser -v 3.4 -r Complex.mo Modelica ModelicaReference ModelicaServices ModelicaTest ModelicaTestConversion4.mo
The workflow would need to be updated to call
-v 3.6
or completely remove-v
option, to rely on the default version.
Thanks, see #4235.
A first draft for #3739 using "selective model extension" introduced in ModelicaSpec 3.6. See also comment https://github.com/modelica/ModelicaStandardLibrary/pull/4091#issuecomment-1801329028.
The approach implemented here is to reduce the number of possible base classes for variants of connector interfaces by introducing just one (or significantly less number of) extended base class containing more/all the concerned connectors at once and to disable selected unused connectors in extending classes.
This PR-draft is about MultiBody library. It introduces base classes
Interfaces.PartialTwoFramesResolve
(which can be renamed for final PR): it contains connectors frame_a, frame_b and frame_resolve, and the "world".Interfaces.PartialFrameResolveConditional
: since several classes utilizes conditionalframe_resolve
connector, the idea is to disable the non-conditional frame_resolve in the inheritedPartialTwoFramesResolve
and to inheritePartialFrameResolveConditional
additionally as followsSome notes:
Interfaces.PartialOneFrame_a
andInterfaces.PartialOneFrame_b
.Forces
andSensors
. After the proof-of-concept, it shall be extended to other multibody classes as well.Forces.WorldTorque
, the diagram and icon layout was changed, since in thePartialTwoFramesResolve
the frame_resolve connector is placed at the icon's bottom boundary (instead of the top).assert(cardinality(frame_a) > 0,...)
is no more used.