modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
453 stars 165 forks source link

Set unit instead of having it in description #4264

Closed HansOlsson closed 6 months ago

HansOlsson commented 6 months ago

Closes #4076 Only that StateGraph model and two uses of "in dB" were changed. In addition to these changes the only other cases were in Modelica.Units.Conversions - cases such as the following:

function to_degC "Convert from kelvin to degree Celsius"
  extends Modelica.Units.Icons.Conversion;
  input SI.Temperature Kelvin "Value in kelvin";
  output Modelica.Units.NonSI.Temperature_degC Celsius "Value in degree Celsius";

I didn't update them, because:

It may be possible to reformulate it in a good way without the redundant unit but I don't know exactly how, and I don't view it as important.

Harisankar-Allimangalath commented 6 months ago

@beutlich can you please review the changes . Thankyou