search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
453 stars 165 forks source link

Delete unused protected parameters ndim, ndim2 and ndim_pointGravity #4266

Closed tobolar closed 6 months ago

tobolar commented 6 months ago

Close #4246

IMO no conversion script is needed for protected parameters.

tobolar commented 6 months ago

If you like you can add it to the list of changed components (breakng compatibilty) already now, see https://github.com/modelica/ModelicaStandardLibrary/issues/4260.

@beutlich Shall I better rebase this PR to beutlich:create_Version_4_1_0? It could make it easier to merge package.mo later on.

beutlich commented 6 months ago

If you like you can add it to the list of changed components (breakng compatibilty) already now, see #4260.

@beutlich Shall I better rebase this PR to beutlich:create_Version_4_1_0? It could make it easier to merge package.mo later on.

No, just do it here.

Harisankar-Allimangalath commented 6 months ago

@beutlich can you please review the changes done by @tobolar , the milestone part is missing here and I hope its ok to go with MSL4.1.0 . Thankyou

Harisankar-Allimangalath commented 6 months ago

@MartinOtter and @tobolar can this PR have the milestone addressing to MSl4.1.0.

Harisankar-Allimangalath commented 6 months ago

Fine for me (if release notes are slighty reformulated).

@beutlich Are you referring to the auto generation of release notes? The implication you refer is not clear to us, so could you please clarify?

tobolar commented 6 months ago

Fine for me (if release notes are slighty reformulated).

@beutlich Are you referring to the auto generation of release notes? The implication you refer is not clear to us, so could you please clarify?

I think @beutlich means his suggestions https://github.com/modelica/ModelicaStandardLibrary/pull/4266#discussion_r1456944752. You have already merged this.

@MartinOtter and @tobolar can this PR have the milestone addressing to MSl4.1.0.

I'm in favor.

beutlich commented 6 months ago

Fine for me (if release notes are slighty reformulated).

@beutlich Are you referring to the auto generation of release notes? The implication you refer is not clear to us, so could you please clarify?

No, I only meant https://github.com/modelica/ModelicaStandardLibrary/pull/4266/commits/0368d773597401440eb834ed4ae0a3d03042a420