search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
453 stars 165 forks source link

Fix syntax errors in ModelicaReference documentation snippets #4275

Closed maltelenz closed 5 months ago

tobolar commented 5 months ago

Btw. there are sometimes used spaces beneath the equal sign: = and :=. But sometimes not. (Which this PR is not about)

maltelenz commented 5 months ago

There is also

y = <strong>if abs</strong>(x) &lt; Modelica.Constants.eps...

in ModelicaReference.Classes.'function' to be fixed similarly.

Fixed.

Btw. there are sometimes used spaces beneath the equal sign: = and :=. But sometimes not. (Which this PR is not about)

Fixed these anyway.

maltelenz commented 5 months ago

@casella Since we are past the cutoff date for 4.1.0, I assume this should technically go in after the branching?

I'll leave this as is for @casella to decide when to push the merge button.

beutlich commented 5 months ago

@casella Since we are past the cutoff date for 4.1.0, I assume this should technically go in after the branching?

I'll leave this as is for @casella to decide when to push the merge button.

Well, this is can be seen as a doc-fix and not as a new feature.

Can you resolve the merge conflict as well? Thanks.

maltelenz commented 5 months ago

Well, this is can be seen as a doc-fix and not as a new feature.

The wiki page says: "no new PRs can be opened"

But if I was the project leader I would accept stuff like this regardless :)

Can you resolve the merge conflict as well? Thanks.

Done.

Harisankar-Allimangalath commented 5 months ago

@casella can you please review the changes .Thankyou