search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

Add redundant algorithm #4284

Closed HansOlsson closed 5 months ago

HansOlsson commented 5 months ago

The recently merged PR #3919 caused a regression in released versions of Dymola, so thus it would be good to have this work-around for the regression included in the release - it's not a new feature. (I'm a bit surprised that it wasn't detected in testing.)

This work-around should be harmless in itself. (Obviously Dymola will be improved.)

HansOlsson commented 5 months ago

@GallLeo I'm not sure if it was detected, it is related to: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Testruns/Dymola/ModelicaTest/_report/ModelicaTest.Math.TestBooleanFunctions/testcase_report.html Basically these three functions will sometimes fail and/or fail to inline.

beutlich commented 5 months ago

I can only guess the regression test of ModelicaTest.Math.TestBooleanFunctions (as confirmed by @Harisankar-Allimangalath in https://github.com/modelica/ModelicaStandardLibrary/pull/3919#issuecomment-1898255473) was not run in Dymola.

HansOlsson commented 5 months ago

@Harisankar-Allimangalath can you back-port this to maint/4.1.0?