modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

Unused and confusing parameters in Modelica.Mechanics.MultiBody.World #4292

Closed otronarp closed 5 months ago

otronarp commented 5 months ago

The parameters defaultN_to_m and defaultNm_to_m in World are unused and doesn't have any impact on the visualization (since 4.0 the scaling of Modelica.Mechanics.MultiBody.Visualizers.SignalArrow is up to the tool). Shouldn't they be removed?

https://github.com/modelica/ModelicaStandardLibrary/blob/7ac7906706d000c1fc67a5812cd866618b63ffaf/Modelica/Mechanics/MultiBody/package.mo#L140-L145

maltelenz commented 5 months ago

3934 :)

HansOlsson commented 5 months ago

3934 :)

I was just going to comment that:

Preferably not!

Dymola does try to use them as default for the tool-specific settings for the specific model.

Similarly as in that one.

otronarp commented 5 months ago

I did feel a bit familiar :) Closing as duplicate of #3934.