Open beutlich opened 4 months ago
Two obvious issues here:
- The top-level directory ModelicaStandardLibrary-maint-4.1.0\ is not needed.
- The library directories miss the version suffix. Not sure if needed, but for now it is not consistent with what's documented at https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release.
Consistency with what's documented is good, but perhaps it's the documentation that needs to be updated? To me, the new packaging looks better than the old one:
MODELICAPATH
, especially when having multiple versions installed at the same time, and the new distribution with a single top level directory for the library solves this nicely. (It's a pity that https://specification.modelica.org/master/packages.html#the-modelica-library-path-modelicapath doesn't mention this need.)
- The old way of putting the version number in a directory with a package.mo inside was against the specification: https://specification.modelica.org/master/packages.html#directory-hierarchy-mapping
Not true: https://specification.modelica.org/master/annotations.html#mapping-of-versions-to-file-system
Not true: https://specification.modelica.org/master/annotations.html#mapping-of-versions-to-file-system
OK, so it wasn't that strange that it looked so familiar after all. Looks like it's time to update Directory Hierarchy Mapping then.
Consistency with what's documented is good
Indeed, that's all what I am aiming for. We should at least stick with our own documentation and guidelines.
This is the library structure of https://github.com/modelica/ModelicaStandardLibrary/releases/download/v4.0.0-beta.1/ModelicaStandardLibrary_v4.0.0-beta.1.zip
and this is how it looks in https://github.com/modelica/ModelicaStandardLibrary/releases/download/v4.1.0-beta.1/ModelicaStandardLibrary_v4.1.0-beta.1.zip
Two obvious issues here: