search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

MSL v4.1.0-beta.1 feedback: Inconsistent experiment annotations in Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates #4309

Closed beutlich closed 4 months ago

beutlich commented 4 months ago

There are 3 example templates in Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates, but only one of them (ChopperBuckBoost) has an experiment annoation.

https://github.com/modelica/ModelicaStandardLibrary/blob/da5c5de71f574b33a4f4631e09ba79682755f6d0/Modelica/Electrical/PowerConverters/Examples/DCDC/ExampleTemplates/ChopperBuckBoost.mo#L112-L115

I'd recommend to remove that experiment annotation on the partial models such that none of the three templates contains an experiment annotation.

casella commented 4 months ago

@Harisankar-Allimangalath @arunkumar-narasimhan, can you pleas port @AHaumer's commit to the maintenance branch and close this ticket. Thanks!

beutlich commented 4 months ago

Resolved in both master and maint/4.1.0.