search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
472 stars 168 forks source link

MSL 4.1.0 Regressions - Electrical and ComplexBlocks #4333

Open GallLeo opened 7 months ago

GallLeo commented 7 months ago

The following models fail in result comparison. Tested revision: f9bddf86 (2024-02-16)

Changed models, need reference update after library officer check:

Not classified yet, needs library officer check:

@GallLeo please note: We have improved the comparisonSignals.txt in PR #4353 of Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.{HBridge_R, HBridge_RL, HBridge_DC_Drive}, also back-ported to maint/4.1.x in #4372. Please create new reference results for all three examples.

Useful Links

_Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html -> Reference result test -> Comparison_

Comparison signal definitions: https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest

_Reference results: https://github.com/modelica/MAP-LIB_ReferenceResults_

maltelenz commented 3 months ago

@GallLeo please note: We have improved the comparisonSignals.txt in PR #4353 of Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.{HBridge_R, HBridge_RL, HBridge_DC_Drive} Please create new reference results for all three examples.

@AHaumer The LTX run actually shows a correctness failure in Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_DC_Drive for the variable meanCurrent.y, so that should be checked specifically before resetting the baseline to get the new variables.

AHaumer commented 3 months ago

@maltelenz @GallLeo The only difference I see is at the beginning of the trajectory of meanCurrent,y. This is caused from improvements in the block SignalPWM. Yes the new signal is correct, and please take the new signal as reference for the future.