Open GallLeo opened 8 months ago
All three points fine to me. @AHaumer after checking the points, you can please tick them all.
@tobolar I won't tick the points, @GallLeo will do that as soon as he has created new reference results.
@Esther-Devakirubai Can you please, whether the release notes mention EddyCurrentBrake?
The following models fail in result comparison. Tested revision: f9bddf86 (2024-02-16)
Changed models, need reference update after library officer check:
[x] Modelica.Mechanics.Rotational.Examples.EddyCurrentBrake
[x] Modelica.Mechanics.Translational.Examples.EddyCurrentBrake
[ ] Release notes check: All classes mentioned which could lead to result changes in user models? @GallLeo could you please feed the explanation to the release notes? Thx a lot!
Useful Links
_Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html -> Reference result test -> Comparison_
Comparison signal definitions: https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest
_Reference results: https://github.com/modelica/MAP-LIB_ReferenceResults_