Open GallLeo opened 4 months ago
Library officer check:
Modelica.Mechanics.MultiBody.Examples.Elementary.PointGravityWithPointMasses2
Checking https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/20240227232653/Modelica.Mechanics.MultiBody.Examples.Elementary.PointGravityWithPointMasses2/CSVCompare/PointGravityWithPointMasses2_report.html,
the error message is: 6 (relative error is 1,81520807176844E-16)
So I really wonder why csv-compare catch this.
Anyway - this example is fine to me.
Modelica.Mechanics.MultiBody.Examples.Rotational3DEffects.BevelGear1D I simulated both MSL400 and MSL4100 in Dymola2023x Refresh1, and then MSL400 and MSL4100 in Dymola2024x. Comparing results of the two MSL versions calculated in ONE of Dymola yields the same results. So the problem seems to be the comparison across the Dymola versions. I tried to increase the numerical tolerance but this alone doesn't help. What seems could help is to a) introduce a damping and b) increase the tolerance (to=1e-6). So maybe better place this under "Change due to new Dymola version" below?
ModelicaTest.MultiBody.Parts.FreeBodies
Checking https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/ModelicaTest/20240228011806/ModelicaTest.MultiBody.Parts.FreeBodies/CSVCompare/FreeBodies_report.html,
the error message is: 433 (relative error is 3,22845694576259E-13)
So I really wonder why csv-compare catch this.
Anyway - this example is fine to me.
ModelicaTest.MultiBody.Sensors.AbsoluteSensor Test model changed, see https://github.com/modelica/ModelicaStandardLibrary/pull/4148 (and esp. 82d1b167e20e0decf632a8c9a2ea58f3c92415cb) So the reference files shall be updated.
No signals to compare, define more comparison signals:
Change due to new Dymola version (reference update after library officer check?):
Not classified, yet (needs library officer check):
Modelica.Mechanics.MultiBody.Examples.Rotational3DEffects.BevelGear1D This item is doubled, see the same class above.
ModelicaTest.MultiBody.PlanarLoopWithMove I can't simulate - maybe missing binaries? https://github.com/modelica/ModelicaStandardLibrary/pull/4250
ModelicaTest.MultiBody.Sensors.Distance2 There is no error reported.
ModelicaTest.MultiBody.Sensors.RelativeSensor There is no error reported.
On 2024-06-18 I reviewed all issues with @tobolar, took decisions, and made actions, as reported in the top ticket description
Modelica.Mechanics.MultiBody.Examples.Rotational3DEffects.BevelGear1D
I tried to reduce the reference CSV to 0.4 s.
It nearly works in csv-compare. Unfortunately, it reports errors for each variable, because the tube extrapolates a bit in the future.
Proposal:
Agreed, as discussed during the 2024-07-02 MAP-Lib meeting
The following models fail in result comparison. Tested revision: f9bddf86 (2024-02-16)
Changed models, need reference update after library officer check:
freeMotion.v_rel_a[2]
, which is very close to zero. The problem here is that CSV compare is just too strict on variables close to zero. One option is to remove the variable until we have a proper solution for that. This is done by PR #4420 (needs to be ported to maint/v4.1.0). However, as discussed in the MAP-Lib meeting 02-07-2024, maybe the best solution is to flag this regression as a false positive and fix the CSV tool to include some absolute tolerance for near-zero signals, see #4421.No signals to compare, define more comparison signals:
Change due to new Dymola version
[ ] ModelicaTest.MultiBody.Joints.Universal
universal.w_a
is zero until about time = 0.3, then it starts showing some oscillations which are growing over time, but are clearly triggered by numerical errors and have a negligible amplitude (2e-8 rad/s). This is also confirmed by looking at the regression in OpenModelica. There is no point trying to reproduce this signal, which clearly only depends on numerical approximations, so until CSV compare can handle that properly, we can remove it in PR #4420 (needs to be ported to maint/v4.1.0). However, as discussed in the MAP-Lib meeting 02-07-2024, maybe the best solution is to flag this regression as a false positive and fix the CSV tool to include some absolute tolerance for near-zero signals, see #4421.[ ] ModelicaTest.MultiBody.Joints.UniversalSpherical
[ ] ModelicaTest.MultiBody.Parts.Rotor1D.GearConstraint3
[X] ModelicaTest.MultiBody.PlanarLoopWithMove
[X] ModelicaTest.MultiBody.Sensors.Distance2
[X] ModelicaTest.MultiBody.Sensors.RelativeSensor
[ ] Release notes check: Are all classes mentioned which could lead to result changes in user models?
Useful Links
_Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html -> Reference result test -> Comparison_
Comparison signal definitions: https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest
_Reference results: https://github.com/modelica/MAP-LIB_ReferenceResults_