search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

MSL 4.1.0 Reference results for new models #4349

Open maltelenz opened 4 months ago

maltelenz commented 4 months ago

MSL 4.1.0 comes with new example models compared to 4.0.0.

These need new reference results at https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0

List of new models:

Modelica.Blocks.Examples.DemonstrateContinuousSignalExtrema
Modelica.Blocks.Examples.DemonstrateSignalExtrema
Modelica.Blocks.Examples.DemoSignalCharacteristic
Modelica.Electrical.Analog.Examples.DemonstrateLightning
Modelica.Electrical.Analog.Examples.DemoPowerSupply
Modelica.Electrical.Analog.Examples.DemoPowerSupplyWithBuffer
Modelica.Electrical.Analog.Examples.Lines.CompareLineTrunks
Modelica.Electrical.Analog.Examples.Lines.CompareLosslessLines
Modelica.Electrical.Analog.Examples.Lines.LightningLosslessTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.LightningSegmentedTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.SmoothStep
Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Drive
Modelica.Electrical.PowerConverters.Examples.DCDC.ChopperBuckBoost.ChopperBuckBoost_DutyCycle
Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates.ChopperBuckBoost
Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
Modelica.Electrical.QuasiStatic.SinglePhase.Examples.MultipleResonance
Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.ComparisonPolyphase.IMC_DOL_CommonLeakage
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Inverter
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_FieldWeakening
Modelica.Mechanics.Rotational.Examples.CompareBrakingTorque
Modelica.Mechanics.Translational.Examples.CompareBrakingForce
ModelicaTest.Blocks.Exponentiation
ModelicaTest.Blocks.ZeroThresholds
ModelicaTest.Electrical.Machines.DCPM_CurrentControlled
ModelicaTest.Electrical.Machines.DCPM_SpeedControlled
ModelicaTest.Electrical.SingularTransformer
ModelicaTest.Fluid.TestComponents.Machines.TestLinearPower
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2
ModelicaTest.MultiBody.Frames.QuaternionFromT
ModelicaTest.Tables.CombiTable1Ds.Test35
ModelicaTest.Tables.CombiTable1Dv.Test35
ModelicaTest.Tables.CombiTable2Ds.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Ds.Test32
ModelicaTest.Tables.CombiTable2Ds.Test33
ModelicaTest.Tables.CombiTable2Dv.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Dv.Test32
ModelicaTest.Tables.CombiTable2Dv.Test33
ModelicaTest.Tables.CombiTimeTable.Test89
beutlich commented 4 months ago

Sure. Already available at https://github.com/beutlich/MAP-LIB_ReferenceResults for patched v4.1.0-beta.1.

beutlich commented 3 months ago

Sure. Already available at for patched v4.1.0-beta.1.

After spending some more time on https://github.com/modelica/ModelicaStandardLibrary/issues/4343 I only noticed now that some of the simulation result is no longer reproducable. Not sure what I did then (beside the too much manual patching). In order not to use it I removed that fork for now. Sorry for the inconvenience.

maltelenz commented 1 month ago

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2
beutlich commented 1 month ago

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2

Confirmed, see #3679 for the first and #3959 for the other two. I actually wonder why I missed them for #4304. (Edit: Fixed by https://github.com/modelica-tools/msl-release/commit/71b4d6a34cb818a7a074764e94efc10cdef9ba04)

@AHaumer @casella This needs to be fixed before tagging a new release.

casella commented 2 weeks ago

For the HBridge_TrianglePWM_RL results, I opened PR #4423 for @AHaumer to check.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.

casella commented 2 weeks ago

For the two new dynamic pipe check models, I opened PR #4425.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.