search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
472 stars 168 forks source link

comparisonSignals of PowerConverters #4353

Closed AHaumer closed 6 months ago

AHaumer commented 7 months ago

improve comparisonSignals.txt of Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.* It doesn't make sense to compare potential and current of positive and negative pin on both sides, better compare voltage and current on both sides. This ensures better regression testing in the future. @arunkumar-narasimhan this should be back-ported to 4.1.x and 4.0.x - thanks!

Harisankar-Allimangalath commented 6 months ago

@GallLeo @beutlich @dietmarw can you please review this , Thanks

Harisankar-Allimangalath commented 6 months ago

FYI @AHaumer @christiankral @hubertus65 I have created a PR to backport this #4372 .

Thankyou