Use sqrt(x) instead of x^0.5 in several places.

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.

https://doc.modelica.org

BSD 3-Clause "New" or "Revised" License

452 stars 165 forks source link

Use sqrt(x) instead of x^0.5 in several places. #4358

Closed HansOlsson closed 3 months ago

HansOlsson commented 3 months ago

Some reasons:

Clarity; it is not an arbitrary exponent that happens to be 0.5, but exactly the square root.
Ease of unit-checking; the proposals handle sqrt specially as well as integer exponents, but not real numbers that happen to be fractions.

Not necessary for 4.1.0 - but not problematic to add either.

Harisankar-Allimangalath commented 3 months ago

@hubertus65 @DagBruck @HansOlsson we have to backport this to main\4.1.x right ?

HansOlsson commented 2 months ago

@hubertus65 @DagBruck @HansOlsson we have to backport this to main\4.1.x right ?

I don't see a need. It will be important for better unit-checking, which is worked on for Modelica 3.7, but currently it works.