Have final modifier for these rescalings.

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.

https://doc.modelica.org

BSD 3-Clause "New" or "Revised" License

472 stars 168 forks source link

Have final modifier for these rescalings. #4379

Open HansOlsson opened 5 months ago

HansOlsson commented 5 months ago

Otherwise these parameters could (as default; depending on tool) be possible to edit after translation. Modifying the rescaling between Pascal and bar (or MW and W) clearly does not make sense.

HansOlsson commented 1 month ago

My intent was to not do anything regarding units in this PR, but only make the rescalings final - as they are clearly not intended to be changed.

HansOlsson commented 1 month ago

As I see it, it is because the units are final that the conversion rates are final. If the intent is to use these blocks for conversion between other units I don't think it makes sense to make the rates final, so I don't see the point of proceeding without also specifying unit. Maybe you can find another reviewer who likes the changes without unit, and if you do I can make a follow-up PR to only add the missing units?

That makes sense. So can some fluid-experts look at the changes?