Add unit="1" to quaternions.

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.

https://doc.modelica.org

BSD 3-Clause "New" or "Revised" License

452 stars 165 forks source link

Add unit="1" to quaternions. #4397

Closed HansOlsson closed 1 day ago

HansOlsson commented 2 months ago

Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications:

It is the correct unit; as it cannot be anything else. (Also clear from the constraint that q*q=1.)
In many cases we could already deduce the unit for the quaternion based on its derivative.

However, if we didn't compute the derivative in a specific model that deduction wouldn't happen. Additionally it seems a bit counter-intuitive to go that indirect route.

HansOlsson commented 5 days ago

What should I do regarding the CLA-check?

casella commented 3 days ago

Looks stuck. No idea why.