search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

Removed unreliable signals very close to zero #4420

Open casella opened 2 weeks ago

casella commented 2 weeks ago

These signals only depend on numerical approximations and CSV compare cannot evaluate them reliably because it lacks information about their magnitude (nominal attribute).

casella commented 2 weeks ago

Once approved, this should be cherry-picked to maint/v4.1.0 as well.

casella commented 5 hours ago

@HansOlsson the more I think of it the more I see you point. These signals are supposed to be near zero, and if we don't check they may (in principle) stray away.

One could argue that they very likely can't do that without some of the non-zero components changing significantly, but at the end of the day this issue can be really fixed by just adding some sensible absolute tolerance to the CVS-compare tool.

I'll keep this on hold for the time being.