modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy uses partial package #4428

Open perost opened 1 week ago

perost commented 1 week ago

ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy is defined as: https://github.com/modelica/ModelicaStandardLibrary/blob/a9c6eabc42058a7b08c5a54f13ac0754ac610b4e/ModelicaTest/Media.mo#L953-L963 However, Modelica.Media.Water.WaterIF97_fixedregion is a partial package, so using it in a simultion model like this is not allowed. Presumably it should just be using one of the non-partial Water mediums instead.

casella commented 1 week ago

This is not a big deal, as it just involves a test model and not a reusable class in the MSL. Nevertheless, the model is invalid, so it should be fixed.

casella commented 5 days ago

Will be fixed by #4429, needs to be ported to maint/4.1.0 afterwards