search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

Fixed illegal ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy #4429

Closed casella closed 1 day ago

casella commented 1 week ago

ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy used the partial medium Modelica.Media.Water.WaterIF97_fixedregion, which is not allowed by the MLS, so it is not valid Modelica code.

This PR replaces the medium model with the non-partial package Modelica.Media.Water.StandardWater

casella commented 1 week ago

After accepting it, this should be back-ported to maint/4.1.0

casella commented 4 days ago

@maltelenz if you can approve this, we can merge it in. Thanks!

casella commented 1 day ago

@maltelenz the only knowledgeable people on Media that are available now are myself and @arunkumar-narasimhan. @rfranke resigned. @hubertus65 also is very competent, but he delegated to Arun because he doesn't have the time. So, I need someone else to rubber-stamp our PRs 😄